Cors 2075 new saga le sa #394
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ap to old version, initial implementation of ServiceAgreementSagaV2
…ORS-2075-new-saga-LE-SA
…ap to old version, initial implementation of ServiceAgreementSagaV2
…ap to old version, initial implementation of ServiceAgreementSagaV2
…ORS-2075-new-saga-LE-SA
…ORS-2075-new-saga-LE-SA # Conflicts: # stream-legal-entity/legal-entity-core/src/main/java/com/backbase/stream/ServiceAgreementSagaV2.java
…ORS-2075-new-saga-LE-SA
…after discussion with Henk
uesleilima
reviewed
Dec 20, 2023
@uesleilima this is an addition, not a breaking change. The new Bootstrap Engine is based on Stream 3, moving to Stream 4 would be a way too big change. |
mostafarastgar
approved these changes
Dec 22, 2023
igorjavadev
approved these changes
Jan 2, 2024
lenach87
approved these changes
Jan 2, 2024
uesleilima
approved these changes
Jan 2, 2024
uesleilima
reviewed
Jan 2, 2024
CHANGELOG.md
Outdated
| @@ -1,6 +1,10 @@ | |||
| # Changelog | |||
| All notable changes to this project will be documented in this file. | |||
|
|
|||
| ## [3.71.0](https://github.com/Backbase/stream-services/compare/3.70.0...3.71.0) | |||
| ### Added | |||
| - Added new models for LE and SA to cover requirements in the new bootstrap. In the new structure, LE supports just master service agreement and custom service agreement has been dropped. Product groups, limits, job profile users, reference job roles, contacts were moved from LE to new SA model. In the new bootstrap, LE and SA are now separated and can be defined in the different JSON files and independently ingested. | |||
There was a problem hiding this comment.
Sounds good! Just a reminder that limits can be ingested at different levels, you can have SA limits, LE limits and User limits, so removing it from the LE model will create limitations on the saga.
There was a problem hiding this comment.
@uesleilima you're right, just removed the limits in the changelog. we have limits for both new SA and LE
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LegalEntityV2, ServiceAgreementV2, LegalEntitySagaV2, and ServiceAgreementSaga are the new models and sagas for the new bootstrap project. We didn't touch the old ones used by other teams.
Checklist